Hean-Chhinling commented on code in PR #8766: URL: https://github.com/apache/hadoop/pull/8766#discussion_r4349230796
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui/src/main/webapp/app/utils/diagnostic-archive.js: ########## @@ -0,0 +1,238 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +const ISSUE_ID = 'application_diagnostic'; + +export function buildBundleFolderName(generatedAt, appId, issueId) { + const safeTs = generatedAt.replace(/[:.]/g, '-'); + const safeAppId = String(appId).replace(/[^\w.-]+/g, '_'); + const safeIssueId = String(issueId || ISSUE_ID).replace(/[^\w.-]+/g, '_'); + return `${safeAppId}_${safeIssueId}_${safeTs}`; +} + +export function normalizeIssueFiles(issueData) { + if (!issueData || !issueData.file) { + return []; + } + + const files = issueData.file; + return Array.isArray(files) ? files : [files]; +} + +export function resolveEntryFileName(filename, contentType, content) { + + if (contentType.indexOf('xml') >= 0 || content.startsWith('<?xml')) { + return `${filename}.xml`; + } + if (contentType.indexOf('json') >= 0 || content.startsWith('{') || content.startsWith('[')) { + return `${filename}.json`; + } + if (filename.indexOf('log') >= 0) { + return `${filename}.log`; + } + + return `${filename}.txt`; +} + +function stringToUtf8Bytes(str) { + if (typeof TextEncoder !== 'undefined') { + return new TextEncoder().encode(str); + } + + return utf8EncodeFallback(str); +} + +function utf8EncodeFallback(str) { + const bytes = []; + for (let i = 0; i < str.length; i++) { + let codePoint = str.charCodeAt(i); + if (codePoint >= 0xd800 && codePoint <= 0xdbff && i + 1 < str.length) { + const next = str.charCodeAt(i + 1); + if (next >= 0xdc00 && next <= 0xdfff) { + codePoint = ((codePoint - 0xd800) << 10) + (next - 0xdc00) + 0x10000; + i++; + } + } + + if (codePoint < 0x80) { + bytes.push(codePoint); + } else if (codePoint < 0x800) { + bytes.push(0xc0 | (codePoint >> 6), 0x80 | (codePoint & 0x3f)); + } else if (codePoint < 0x10000) { + bytes.push( + 0xe0 | (codePoint >> 12), + 0x80 | ((codePoint >> 6) & 0x3f), + 0x80 | (codePoint & 0x3f), + ); + } else { + bytes.push( + 0xf0 | (codePoint >> 18), + 0x80 | ((codePoint >> 12) & 0x3f), + 0x80 | ((codePoint >> 6) & 0x3f), + 0x80 | (codePoint & 0x3f), + ); + } + } + return new Uint8Array(bytes); +} + +const CRC32_TABLE = (function buildCrc32Table() { + const table = new Uint32Array(256); + for (let i = 0; i < 256; i++) { + let c = i; + for (let j = 0; j < 8; j++) { + c = (c & 1) ? (0xedb88320 ^ (c >>> 1)) : (c >>> 1); + } + table[i] = c >>> 0; + } + return table; +}()); + +function crc32(bytes) { + let crc = 0xffffffff; + for (let i = 0; i < bytes.length; i++) { + crc = CRC32_TABLE[(crc ^ bytes[i]) & 0xff] ^ (crc >>> 8); + } + return (crc ^ 0xffffffff) >>> 0; +} + +function writeUint32LE(view, offset, value) { + view.setUint32(offset, value, true); +} + +function writeUint16LE(view, offset, value) { + view.setUint16(offset, value, true); +} + +/** + * Build a ZIP archive (stored, no compression) containing one top-level folder. + */ +export function buildDiagnosticZipBlob(folderName, entries) { Review Comment: Thank you for your detailed feedback, I really appreciate it. My bad that I missed these points. I will fix the code in my next commit along with the unit-tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
