[
https://issues.apache.org/jira/browse/HADOOP-20018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18132710#comment-18132710
]
ASF GitHub Bot commented on HADOOP-20018:
-----------------------------------------
hadoop-yetus commented on PR #8873:
URL: https://github.com/apache/hadoop/pull/8873#issuecomment-6434552797
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 7m 21s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 28m 51s | | trunk passed |
| +1 :green_heart: | compile | 8m 41s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 9m 0s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 0m 55s | | trunk passed |
| +1 :green_heart: | mvnsite | 1m 14s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 55s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 53s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 1m 53s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 19s | | branch has no errors
when building and testing our client artifacts. |
| -0 :warning: | patch | 17m 36s | | Used diff version of patch file.
Binary files and potentially other changes not applied. Please rebase and
squash commits if necessary. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 39s | | the patch passed |
| +1 :green_heart: | compile | 8m 18s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 8m 18s | | the patch passed |
| +1 :green_heart: | compile | 9m 4s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 9m 4s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 0m 51s | | the patch passed |
| +1 :green_heart: | mvnsite | 1m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 53s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 51s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 1m 54s | | the patch passed |
| +1 :green_heart: | shadedclient | 17m 12s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 19m 17s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 139m 19s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8873/1/artifact/out/Dockerfile
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux d267ddaf3a94 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f842297570243587f0ed7a81ebe80bb178098bca |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8873/1/testReport/ |
| Max. process+thread count | 3153 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8873/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> ZKFC exits with a NullPointerException that hides the BindException when its
> RPC port is in use
> -----------------------------------------------------------------------------------------------
>
> Key: HADOOP-20018
> URL: https://issues.apache.org/jira/browse/HADOOP-20018
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha
> Affects Versions: 3.6.0
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
> Attachments: hadoop20018.sh
>
>
> *Problem*: when the ZKFC cannot bind its RPC port ({{dfs.ha.zkfc.port}}, 8019
> by default), for example because another ZKFC or a stale process holds it, it
> exits with a NullPointerException. The BindException that explains the
> failure is logged once, but the exit status and the final error both name the
> NullPointerException:
> {noformat}
> ERROR org.apache.hadoop.ha.ZKFailoverController: The failover controller
> encounters runtime error:
> java.net.BindException: Problem binding to [localhost:8019]
> java.net.BindException: Address already in use; For more details see:
> http://wiki.apache.org/hadoop/BindException
> Caused by: java.net.BindException: Address already in use
> ERROR org.apache.hadoop.hdfs.tools.DFSZKFailoverController:
> DFSZKFailOverController exiting due to earlier exception
> java.lang.NullPointerException: Cannot invoke
> "org.apache.hadoop.ha.ZKFCRpcServer.stopAndJoin()" because "this.rpcServer"
> is null
> INFO org.apache.hadoop.util.ExitUtil: Exiting with status 1:
> java.lang.NullPointerException: Cannot invoke
> "org.apache.hadoop.ha.ZKFCRpcServer.stopAndJoin()" because "this.rpcServer"
> is null
> {noformat}
> *Cause*: in {{ZKFailoverController.doRun()}}, {{initRPC()}} throws before
> {{rpcServer}} is assigned (the {{ZKFCRpcServer}} constructor fails to bind),
> and the {{finally}} block calls {{rpcServer.stopAndJoin()}} without a null
> check. The NullPointerException thrown from {{finally}} replaces the
> BindException in flight, so {{DFSZKFailoverController}} reports and exits
> with the NullPointerException.
> *To reproduce*: two namenodes of one HA nameservice on the same host without
> a distinct {{dfs.ha.zkfc.port}} each, then start both ZKFCs. The second one
> fails as above. (Any process listening on 8019 does the same.)
> *Proposed fix*: in the {{finally}} block of {{doRun()}}, call
> {{rpcServer.stopAndJoin()}} only when {{rpcServer}} is not null (the
> {{healthMonitor}} next to it already has that check), so the BindException
> reaches the caller and the exit message. A unit test can occupy the ZKFC port
> with a {{ServerSocket}} before starting the controller and assert that the
> exception reported is the BindException.
> *Related*: HADOOP-18831 reports the same unchecked
> {{rpcServer.stopAndJoin()}}, reached through a misconfigured
> {{ipc.server.handler.queue.size}}; HADOOP-18811 another way {{rpcServer}} can
> end up null. This issue is the operational case: a port conflict, where the
> hidden BindException is what an operator needs to see. The same null check
> fixes all three paths.
> Found during the Jetty 12 (EE8) migration testing (HADOOP-19912), by an
> end-to-end test of an HA cluster built from trunk. The bug is on trunk
> itself; the migration does not cause it.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
