smengcl opened a new pull request, #8880: URL: https://github.com/apache/hadoop/pull/8880
Generated-by: Claude Code (Opus 5.5) JIRA: https://issues.apache.org/jira/browse/HADOOP-20040 ### Description of PR With `hadoop.security.hostname.cache.expire-interval.seconds` > 0, `SecurityUtil.CacheableHostResolver` (HADOOP-19447) hands the same `InetAddress` instance to every caller resolving the same host, and `NetUtils.createSocketAddrForHost` wraps it directly. For an IP literal resolved by `StandardHostResolver` (the default, `use_ip=true`), the first `getHostName()` call stores the reverse lookup result in that shared object, so every later `getHostString()` for that IP in the JVM returns the PTR name instead of the literal. This change skips the cache for IP literals. Resolving a literal needs no DNS lookup, so caching it saves nothing, and literals behave exactly as they did with the cache off. Hostnames stay cached. Returning a copy via `InetAddress.getByAddress(host, bytes)` was not used because it would make `getHostName()` skip the reverse lookup, which changes behavior on its own. ### How was this patch tested? `TestSecurityUtil` (29 tests) passes locally. The new `testCacheableResolverDoesNotShareIpLiteral` covers `127.0.0.1`, `::1` and `[::1]` and fails without the fix (`expected: not same but was: <localhost/127.0.0.1>`). `testCacheableResolve` used `127.0.0.1` to check cache hits, so it now uses `localhost` and checks the cache entry directly, since the JDK returns the same object for a hostname from its own lookup cache. ### For code changes: - [x] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')? - [ ] Object storage: Have the integration tests been executed and the endpoint declared according to the connector-specific documentation? *Note: Automated CI testing doesn't cover all cases so manual testing with cloud storage is still required.* - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files? ### AI Tooling If an AI tool was used: - [x] The PR includes the phrase "Contains content generated by <tool>" where <tool> is the name of the AI tool used. - [x] My use of AI contributions follows the ASF legal policy https://www.apache.org/legal/generative-tooling.html Contains content generated by Claude Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
