GauthamBanasandra commented on code in PR #8844: URL: https://github.com/apache/hadoop/pull/8844#discussion_r4426603619
########## dev-support/docker/Dockerfile_windows_10: ########## @@ -50,54 +50,56 @@ RUN powershell Copy-Item -Recurse -Path 'C:\Program Files\Git' -Destination C:\G RUN powershell git clone https://github.com/microsoft/vcpkg.git \ && cd vcpkg \ && git fetch --all \ - && git checkout 2025.03.19 \ + && git checkout 2026.07.29 \ && .\bootstrap-vcpkg.bat ADD vcpkg/vcpkg.json . RUN powershell .\vcpkg\vcpkg.exe install --x-install-root .\vcpkg\installed -# Install Azul Java 8 JDK. -RUN powershell Invoke-WebRequest -URI https://cdn.azul.com/zulu/bin/zulu8.62.0.19-ca-jdk8.0.332-win_x64.zip -OutFile $Env:TEMP\zulu8.62.0.19-ca-jdk8.0.332-win_x64.zip -RUN powershell Expand-Archive -Path $Env:TEMP\zulu8.62.0.19-ca-jdk8.0.332-win_x64.zip -DestinationPath "C:\Java" +# Install Microsoft Build of OpenJDK 17. +RUN powershell Invoke-WebRequest -URI https://aka.ms/download-jdk/microsoft-jdk-17.0.20.1-windows-x64.msi -OutFile C:\jdk17.msi +RUN powershell Start-Process msiexec.exe -ArgumentList '/i','C:\jdk17.msi','INSTALLDIR=C:\Java\jdk17\','/quiet','/norestart' -Wait Review Comment: Added in 46038bf1. All nine downloaded artifacts now verify SHA-512 via `Get-FileHash` before use, matching the pattern `pkg-resolver/install-pip.ps1` already uses for `get-pip.py`. Where the publisher ships its own digest I checked against it before deriving the SHA-512, so these aren't just self-attested: Microsoft publishes SHA-256 for the JDK, cmake.org for CMake, and the ASF publishes SHA-512 for Maven. All three matched. Every gate was exercised in a full image rebuild. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
