[
https://issues.apache.org/jira/browse/HADOOP-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jose Luis López updated HADOOP-20015:
-------------------------------------
Description:
*Scope*:
* hadoop-yarn-server-applicationhistoryservice/pom.xml:
ApplicationHistoryServer uses org.eclipse.jetty.webapp.WebAppContext and
org.eclipse.jetty.servlet.FilterHolder. Declare jetty-webapp and jetty-servlet
with scope provided, the scope they already resolve at through the provided
hadoop-common.
* hadoop-yarn-server-router/pom.xml: Router serves the UI2 war through
WebAppContext. Declare jetty-webapp at compile scope. A test scope would
override the inherited compile scope and take it off the Router's runtime
classpath.
* hadoop-yarn-server-resourcemanager/pom.xml: ResourceManager hosts UI2 through
WebAppContext. Declare jetty-webapp with scope provided, the scope it already
resolves at.
* hadoop-yarn-common/pom.xml: WebApps, which Router and the ResourceManager
call, exposes WebAppContext in its API. Declare jetty-webapp with scope
provided, the scope it already resolves at.
* TestRollingLevelDBTimelineStore (applicationhistoryservice), TestAMRMClient,
TestYarnCLI (yarn-client) and MockNM (resourcemanager): they logged through
org.eclipse.jetty.util.log.Log, which Jetty 10 and later no longer have. Log
through SLF4J instead.
* TestDockerCommandExecutor (nodemanager): it borrowed a logger from Jetty's
GzipHttpOutputInterceptor. Give it its own.
* FederationInterceptor (nodemanager): replace Jetty's ConcurrentHashSet, which
Jetty 12 no longer has, with ConcurrentHashMap.newKeySet().
*Why*: these modules compile against Jetty that they only get transitively.
Declaring it makes the HADOOP-19972 change a rename of these entries to
jetty-ee8-*.
*Impact on Jetty 9*: none. Same artifacts, version and scope as today, and the
logging and set changes behave the same.
*Downstream*: none.
*CI*: six modules (applicationhistoryservice, router, resourcemanager,
yarn-common, yarn-client, nodemanager).
*PR*: https://github.com/apache/hadoop/pull/8893
was:
*Scope*:
* hadoop-yarn-server-applicationhistoryservice/pom.xml:
ApplicationHistoryServer uses org.eclipse.jetty.webapp.WebAppContext and
org.eclipse.jetty.servlet.FilterHolder. Declare jetty-webapp and jetty-servlet
with scope provided, the scope they already resolve at through the provided
hadoop-common.
* hadoop-yarn-server-router/pom.xml: Router serves the UI2 war through
WebAppContext. Declare jetty-webapp at compile scope. A test scope would
override the inherited compile scope and take it off the Router's runtime
classpath.
* hadoop-yarn-server-resourcemanager/pom.xml: ResourceManager hosts UI2 through
WebAppContext. Declare jetty-webapp with scope provided, the scope it already
resolves at.
* hadoop-yarn-common/pom.xml: WebApps, which Router and the ResourceManager
call, exposes WebAppContext in its API. Declare jetty-webapp with scope
provided, the scope it already resolves at.
* TestRollingLevelDBTimelineStore (applicationhistoryservice): it logged
through org.eclipse.jetty.util.log.Log, which Jetty 10 and later no longer
have. Log through SLF4J instead.
*Why*: these modules compile against Jetty that they only get transitively.
Declaring it makes the HADOOP-19972 change a rename of these entries to
jetty-ee8-*.
*Impact on Jetty 9*: none. Same artifacts, version and scope as today.
*Downstream*: none.
*CI*: four modules (applicationhistoryservice, router, resourcemanager,
yarn-common).
*PR*: https://github.com/apache/hadoop/pull/8893
Summary: YARN - Declare the Jetty web artifacts in use, and drop
Jetty's Log and ConcurrentHashSet (was: YARN - Declare the Jetty web artifacts
that yarn-common, the ResourceManager, the ApplicationHistoryServer and the
Router use)
> YARN - Declare the Jetty web artifacts in use, and drop Jetty's Log and
> ConcurrentHashSet
> -----------------------------------------------------------------------------------------
>
> Key: HADOOP-20015
> URL: https://issues.apache.org/jira/browse/HADOOP-20015
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Scope*:
> * hadoop-yarn-server-applicationhistoryservice/pom.xml:
> ApplicationHistoryServer uses org.eclipse.jetty.webapp.WebAppContext and
> org.eclipse.jetty.servlet.FilterHolder. Declare jetty-webapp and
> jetty-servlet with scope provided, the scope they already resolve at through
> the provided hadoop-common.
> * hadoop-yarn-server-router/pom.xml: Router serves the UI2 war through
> WebAppContext. Declare jetty-webapp at compile scope. A test scope would
> override the inherited compile scope and take it off the Router's runtime
> classpath.
> * hadoop-yarn-server-resourcemanager/pom.xml: ResourceManager hosts UI2
> through WebAppContext. Declare jetty-webapp with scope provided, the scope it
> already resolves at.
> * hadoop-yarn-common/pom.xml: WebApps, which Router and the ResourceManager
> call, exposes WebAppContext in its API. Declare jetty-webapp with scope
> provided, the scope it already resolves at.
> * TestRollingLevelDBTimelineStore (applicationhistoryservice),
> TestAMRMClient, TestYarnCLI (yarn-client) and MockNM (resourcemanager): they
> logged through org.eclipse.jetty.util.log.Log, which Jetty 10 and later no
> longer have. Log through SLF4J instead.
> * TestDockerCommandExecutor (nodemanager): it borrowed a logger from Jetty's
> GzipHttpOutputInterceptor. Give it its own.
> * FederationInterceptor (nodemanager): replace Jetty's ConcurrentHashSet,
> which Jetty 12 no longer has, with ConcurrentHashMap.newKeySet().
> *Why*: these modules compile against Jetty that they only get transitively.
> Declaring it makes the HADOOP-19972 change a rename of these entries to
> jetty-ee8-*.
> *Impact on Jetty 9*: none. Same artifacts, version and scope as today, and
> the logging and set changes behave the same.
> *Downstream*: none.
> *CI*: six modules (applicationhistoryservice, router, resourcemanager,
> yarn-common, yarn-client, nodemanager).
> *PR*: https://github.com/apache/hadoop/pull/8893
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
