[
https://issues.apache.org/jira/browse/HADOOP-20012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18135626#comment-18135626
]
ASF GitHub Bot commented on HADOOP-20012:
-----------------------------------------
hadoop-yetus commented on PR #8890:
URL: https://github.com/apache/hadoop/pull/8890#issuecomment-6539818390
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 23s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 5s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 27m 45s | | trunk passed |
| +1 :green_heart: | compile | 3m 46s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 3m 55s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | mvnsite | 1m 10s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 8s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 6s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 58m 0s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 41s | | the patch passed |
| +1 :green_heart: | compile | 3m 28s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 3m 28s | | the patch passed |
| +1 :green_heart: | compile | 3m 53s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 3m 53s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 1m 1s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 0s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 58s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 21m 11s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 49s | |
hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. |
| +1 :green_heart: | unit | 0m 47s | |
hadoop-yarn-applications-catalog-webapp in the patch passed. |
| +1 :green_heart: | asflicense | 0m 43s | | The patch does not
generate ASF License warnings. |
| | | 99m 53s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8890/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8890 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux 23b93f97e9d2 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c349c935baa0be09b0e45955e2379ab386576105 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8890/2/testReport/ |
| Max. process+thread count | 1295 (vs. ulimit of 10000) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
U: hadoop-yarn-project/hadoop-yarn |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8890/2/console |
| versions | git=2.43.0 maven=3.9.15 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> YARN - Exclude third-party Jetty and servlet API from the catalog-webapp and
> timelineservice-hbase tests
> --------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-20012
> URL: https://issues.apache.org/jira/browse/HADOOP-20012
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: test, yarn
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> *Scope*:
> * hadoop-yarn-applications-catalog-webapp/pom.xml: solr-test-framework
> already depends on solr-core (where EmbeddedSolrServer and NodeConfig live),
> so drop the direct solr-core declaration and keep solr-test-framework (test
> scope) as the only Solr test dependency. It carries the single exclusion list
> of Solr's own Jetty modules and servlet API: jetty-io, jetty-xml, jetty-http,
> jetty-client, jetty-alpn-client, jetty-alpn-java-client, jetty-alpn-server,
> jetty-alpn-java-server, jetty-continuation, jetty-deploy, jetty-jmx,
> jetty-rewrite, jetty-security, jetty-servlets, http2-hpack, http2-client,
> http2-common, http2-http-client-transport, http2-server,
> javax.servlet:javax.servlet-api, plus commons-collections and jcl-over-slf4j.
> A Solr upgrade that adds a Jetty artifact needs one entry (review on PR
> #8699).
> * jetty-alpn-java-client: Solr declares 9.4.44, and the managed 9.4.58 copy
> won only through Maven's declaration-order tie-break via
> http2-http-client-transport. Exclude it, as solr-solrj already does.
> * hadoop-yarn-server-timelineservice-hbase-tests/pom.xml: on hbase-server and
> hbase-server:tests (test scope), exclude javax.servlet:javax.servlet-api
> 3.1.0. HBase's shaded Jetty uses the javax.servlet API, which the module
> still gets through hadoop-common: today javax.servlet-api 3.1.0, and
> jetty-servlet-api 4.0.9 after HADOOP-19970. hbase-server-2 already excludes
> it the same way.
> *Why*: the catalog-webapp tests reach Solr only through EmbeddedSolrServer,
> which runs no servlet container. Solr's Jetty (9.4.44) lags Hadoop's managed
> Jetty, so today the module's test classpath holds two Jetty releases. After
> this change only ${jetty.version} is left. hbase-server 2.6.3 is the only
> third-party dependency outside Solr that brings its own servlet API; without
> the exclusion, timelineservice-hbase-tests would keep a second servlet API
> jar after HADOOP-19970.
> *Impact on Jetty 9*: none. All the changed dependencies are test scope, and
> catalog-webapp's main code uses only solrj. solr-core 8.11.2 stays on the
> test classpath through solr-test-framework: dependency:list (test scope) of
> catalog-webapp gives the same 238 artifacts with the single list as with the
> exclusions on both Solr artifacts. In timelineservice-hbase-tests the same
> javax.servlet-api 3.1.0 jar still arrives through hadoop-common until
> HADOOP-19970.
> *Downstream*: none.
> *CI*: two modules.
> *PR*: https://github.com/apache/hadoop/pull/8890
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
