[
https://issues.apache.org/jira/browse/HADOOP-20044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18136892#comment-18136892
]
ASF GitHub Bot commented on HADOOP-20044:
-----------------------------------------
hadoop-yetus commented on PR #8913:
URL: https://github.com/apache/hadoop/pull/8913#issuecomment-6590715932
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 19m 17s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 9 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 38s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 57m 59s | | trunk passed |
| +1 :green_heart: | compile | 20m 59s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 21m 14s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 6m 5s | | trunk passed |
| +1 :green_heart: | mvnsite | 3m 25s | | trunk passed |
| +1 :green_heart: | javadoc | 2m 24s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 2m 24s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 5m 34s | | trunk passed |
| +1 :green_heart: | shadedclient | 36m 11s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 15s | | the patch passed |
| +1 :green_heart: | compile | 20m 26s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 20m 26s | | the patch passed |
| +1 :green_heart: | compile | 22m 0s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 22m 0s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 6m 4s | | root: The patch generated
0 new + 11 unchanged - 1 fixed = 11 total (was 12) |
| +1 :green_heart: | mvnsite | 3m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 2m 21s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 2m 23s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 6m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 35m 45s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 27m 10s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 4m 28s | | hadoop-aws in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 28s | | The patch does not
generate ASF License warnings. |
| | | 319m 37s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8913/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8913 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle |
| uname | Linux c6eabc6fba16 5.15.0-198-generic #208-Ubuntu SMP Fri Sep 4
10:22:38 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 6a2df18e8bf10937feca8b55a5aff3b65893c580 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8913/2/testReport/ |
| Max. process+thread count | 1257 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common hadoop-tools/hadoop-aws
U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8913/2/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> S3A: enable shared AWS client schedulers by default and fix pool-test
> isolation
> -------------------------------------------------------------------------------
>
> Key: HADOOP-20044
> URL: https://issues.apache.org/jira/browse/HADOOP-20044
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs/s3
> Reporter: Konstantin Bereznyakov
> Priority: Major
> Labels: pull-request-available
>
> HADOOP-19862 introduced shared scheduled thread pools for S3A’s AWS clients.
> During review, we agreed to keep them opt-in initially and change the
> defaults in a follow-up. This is that follow-up.
> Enable all four pools—S3 sync, S3 async, STS and KMS—by default. Keep the
> existing flags as opt-outs and leave pool sizes and idle timeouts unchanged.
> The same PR should fix the enabled/disabled tests’ isolation. Their pool
> settings are remembered for the life of the JVM, so reusing a test JVM can
> make the result depend on which class runs first. The Javadocs edits from
> HADOOP-19862 also overstate when separate forks are guaranteed.
> h2. The change scope:
> * Consistent XML and Java defaults, with tests for explicit opt-out.
> * Reliable on/off tests in both execution orders and sequential/parallel
> profiles.
> * [Possibly] A regression check for multipart-copy auditing, including
> retries.
> h2. A follow-up review also raised these questions:
> * Should we change the test-only accessor visibility? STS and KMS accessors
> are public, while the S3 equivalents are package-private.
> * Can the thread-counting helper avoid collecting stack frames when it only
> needs thread names?
> * Would simplifying getters or sharing test scaffolding help the isolation
> correction?
> * Is parallel filesystem creation worthwhile in the test helper?
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
