pan3793 commented on PR #8892: URL: https://github.com/apache/hadoop/pull/8892#issuecomment-6620945734
+1 for the direction of this PR. but it's unclear to me why `jetty-util` should be declared as optional for `hadoop-client-minicluster`. 1) Who consumes it at runtime? 2) If nobody does, we should exclude it. 3) If someone does, can it be shaded and relocated instead of being declared as an optional transitive dependency? The intention of `hadoop-client-*` is to shade everything except: 1) hadoop public api; 2) well-known stable api like slf4j; 3) dependencies that contain native libraries that do not support relocation, e.g., snappy-java. I don't think `jetty-util` belongs to any of these -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
