[
https://issues.apache.org/jira/browse/HADOOP-20000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139075#comment-18139075
]
ASF GitHub Bot commented on HADOOP-20000:
-----------------------------------------
hadoop-yetus commented on PR #8940:
URL: https://github.com/apache/hadoop/pull/8940#issuecomment-6664786428
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 28s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 30m 22s | | trunk passed |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | mvnsite | 0m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 32s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 30s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 50m 40s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 14s | | the patch passed |
| +1 :green_heart: | compile | 0m 14s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 0m 14s | | the patch passed |
| +1 :green_heart: | compile | 0m 15s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 0m 15s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 0m 17s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 0m 12s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 24m 8s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 8m 39s | |
hadoop-yarn-server-timelineservice-hbase-tests in the patch passed. |
| +1 :green_heart: | asflicense | 0m 25s | | The patch does not
generate ASF License warnings. |
| | | 86m 28s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8940/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8940 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux 51ae51514cf6 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 76cf19a826b7893d6fc19a6aed5c10cf5aa3b3b0 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8940/1/testReport/ |
| Max. process+thread count | 1284 (vs. ulimit of 10000) |
| modules | C:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
U:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
|
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8940/1/console |
| versions | git=2.43.0 maven=3.9.15 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Remove the JAX-RS 1.1 API from hadoop-yarn-server-timelineservice-hbase-tests
> -----------------------------------------------------------------------------
>
> Key: HADOOP-20000
> URL: https://issues.apache.org/jira/browse/HADOOP-20000
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> Sub-task of HADOOP-19912; follows HADOOP-19970.
> h3. Problem
> {{hadoop-yarn-server-timelineservice-hbase-tests}} declares
> {{javax.ws.rs:jsr311-api:1.1.1}}, the JAX-RS 1.1 API that Jersey 1 used. It
> was added by YARN-5976 (2016) for HBase 1.2. The same module also gets
> {{jakarta.ws.rs:jakarta.ws.rs-api:2.1.6}} (JAX-RS 2.1) through Jersey 2. Both
> jars provide the {{javax.ws.rs}} package, so the module's classpath carries
> two JAX-RS API versions, and which class wins depends on classpath order.
> HADOOP-19970 removes this kind of duplicate for Jetty and the servlet API.
> This does the same for JAX-RS.
> h3. Evidence
> {noformat}
> $ mvn dependency:tree -am -pl
> hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase-tests
> -Dincludes=javax.ws.rs,jakarta.ws.rs
> org.apache.hadoop:hadoop-yarn-server-timelineservice-hbase-tests:jar:3.6.0-SNAPSHOT
> +-
> org.apache.hadoop:hadoop-yarn-server-timelineservice:jar:3.6.0-SNAPSHOT:test
> | \- jakarta.ws.rs:jakarta.ws.rs-api:jar:2.1.6:test
> \- javax.ws.rs:jsr311-api:jar:1.1.1:compile
> {noformat}
> The JAX-RS 2.1 API wins today only because it comes first in the dependency
> tree. The module's tests use JAX-RS 2 APIs, so {{jsr311-api}} appears unused.
> This is the only POM in the repository that declares it, and no other
> dependency of the module brings a JAX-RS 1.x API.
> h3. Change
> * Remove the {{jsr311-api}} dependency from the module's POM.
> * Check with {{mvn dependency:tree}} that no other path brings {{jsr311-api}}
> or another JAX-RS 1.x API onto the classpath. Exclude it there if one does.
> h3. Done when
> * {{javax.ws.rs:jsr311-api}} is on no module classpath of the trunk build.
> * The module's tests pass.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
