joseluisll commented on code in PR #8893:
URL: https://github.com/apache/hadoop/pull/8893#discussion_r4489637047
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java:
##########
@@ -1495,7 +1495,9 @@ void checkEvents(EventHandler<T> eventHandler,
}
}
}
- failures.ifExceptionThrow();
+ if (!failures.isEmpty()) {
+ throw new MultipleFailuresError("checkEvents", failures);
Review Comment:
Done in the new head: `checkEvents` keeps the `addSuppressed` lines, so each
failure keeps its stack trace, the way `assertAll` and the old trunk code did:
```java
MultipleFailuresError error = new MultipleFailuresError("checkEvents",
failures);
failures.forEach(error::addSuppressed);
throw error;
```
Thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
