[
https://issues.apache.org/jira/browse/HADOOP-20016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139540#comment-18139540
]
ASF GitHub Bot commented on HADOOP-20016:
-----------------------------------------
hadoop-yetus commented on PR #8894:
URL: https://github.com/apache/hadoop/pull/8894#issuecomment-6681970080
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 23s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 0s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 19s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 30m 6s | | trunk passed |
| +1 :green_heart: | compile | 10m 2s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 10m 59s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | mvnsite | 8m 57s | | trunk passed |
| +1 :green_heart: | javadoc | 7m 27s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 7m 3s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 95m 12s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 31s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 5m 48s | | the patch passed |
| +1 :green_heart: | compile | 10m 13s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 10m 13s | | the patch passed |
| +1 :green_heart: | compile | 10m 59s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 10m 59s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 8m 34s | | the patch passed |
| +1 :green_heart: | javadoc | 6m 57s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 7m 37s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 44m 4s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 26s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 18m 31s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 184m 44s | | hadoop-hdfs in the patch
passed. |
| +1 :green_heart: | unit | 4m 7s | | hadoop-hdfs-httpfs in the patch
passed. |
| +1 :green_heart: | unit | 4m 25s | | hadoop-yarn-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 12s | |
hadoop-yarn-server-applicationhistoryservice in the patch passed. |
| +1 :green_heart: | unit | 1m 23s | | hadoop-yarn-server-web-proxy in
the patch passed. |
| +1 :green_heart: | unit | 91m 16s | |
hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | unit | 23m 12s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 1m 10s | | hadoop-mapreduce-client-shuffle
in the patch passed. |
| +1 :green_heart: | unit | 92m 20s | |
hadoop-mapreduce-client-jobclient in the patch passed. |
| +1 :green_heart: | unit | 9m 20s | | hadoop-yarn-server-router in
the patch passed. |
| +1 :green_heart: | unit | 1m 20s | | hadoop-sls in the patch passed.
|
| +1 :green_heart: | asflicense | 1m 1s | | The patch does not
generate ASF License warnings. |
| | | 605m 2s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8894/7/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8894 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux 6b9374f2b583 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / c6aa864bbefff5a8b89754da22e4d58ab5912a5e |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8894/7/testReport/ |
| Max. process+thread count | 4498 (vs. ulimit of 10000) |
| modules | C: hadoop-project hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router
hadoop-tools/hadoop-sls U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8894/7/console |
| versions | git=2.43.0 maven=3.9.15 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Declare the Jetty artifacts each module imports directly
> --------------------------------------------------------
>
> Key: HADOOP-20016
> URL: https://issues.apache.org/jira/browse/HADOOP-20016
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: mapreduce
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> *Scope*: every module that imports Jetty classes from an artifact it only
> receives transitively declares that artifact, at the scope it already
> resolves at:
> * hadoop-project/pom.xml: manage jetty-http and jetty-io at ${jetty.version}.
> Neither is managed today.
> * jetty-http, imported by HttpServer2 and McpHttpServer (hadoop-common),
> ShuffleChannelHandler (mapreduce-client-shuffle), TestJettyHelper
> (hadoop-hdfs-httpfs) and SLSWebApp (hadoop-sls): declare it optional in
> hadoop-common, mapreduce-client-shuffle and hadoop-hdfs-httpfs, and provided
> in hadoop-sls, like the module's jetty-server.
> * jetty-webapp, used through WebAppContext: declare it provided in
> yarn-common (WebApps exposes WebAppContext), resourcemanager and
> applicationhistoryservice (which also gets jetty-servlet, provided, for
> FilterHolder), and at compile scope in the router, which serves the UI2 war.
> A test scope would take it off the Router's runtime classpath.
> * hadoop-hdfs: TransferFsImage imports org.eclipse.jetty.io.EofException.
> Declare jetty-io, optional.
> * hadoop-hdfs-httpfs (tests): declare jetty-servlet, and jetty-util as
> optional.
> * hadoop-mapreduce-client-jobclient (tests): declare jetty-server and
> jetty-servlet, provided.
> * hadoop-yarn-server-nodemanager: TerminalServlet extends DefaultServlet.
> Declare jetty-servlet.
> * hadoop-yarn-server-router (tests): declare jetty-server, jetty-servlet and
> jetty-util.
> * hadoop-yarn-server-web-proxy (tests): declare jetty-servlet, provided, and
> jetty-util.
> *Out of scope*: the websocket artifacts, which Jetty 12 replaces entirely;
> the NodeManager and yarn-client already declare one each.
> *Why*: these modules compile against Jetty they only get transitively, mostly
> through hadoop-common. Declaring it records each module's direct Jetty use
> for the Jetty 12 ee8 upgrade (HADOOP-19972) and the later jakarta migration
> (HADOOP-19395), where hadoop-common may stop exporting some of these
> artifacts.
> *Why optional*: it keeps the declaration for compiling each module without
> passing it on, so what downstream projects resolve does not change. At plain
> compile scope it did: Maven's nearest-wins mediation picked Hadoop's
> jetty-http over another one at the same depth, and a project with
> jetty-client 9.4.40 next to hadoop-common resolved jetty-http 9.4.58 instead
> of 9.4.40. jetty-io in hadoop-hdfs and jetty-util in hadoop-hdfs-httpfs
> reached those modules only through jetty-server, so they are optional for the
> same reason. In the shuffle handler, trunk already resolves jetty-http at
> compile scope (through the NodeManager and mapreduce-client-common); optional
> keeps that, whereas provided would change it (review on PR #8699). It is not
> copied into the mapreduce lib directory.
> *Impact on Jetty 9*: none. pom changes only. Every artifact already resolves
> at 9.4.58 in each module, at the same scope, so each module's dependency tree
> is unchanged.
> *Downstream*: none. Projects that depend on these modules keep resolving the
> same Jetty artifacts.
> *CI*: touches hadoop-project, so a full build.
> *PR*: https://github.com/apache/hadoop/pull/8894
> Regrouped on 2026-11-04 by kind of change, as suggested in the review: this
> issue now holds all the pom changes that were split between HADOOP-20015
> (YARN) and HADOOP-20016 (HADOOP); HADOOP-20015 holds all the Java changes.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
