[
https://issues.apache.org/jira/browse/HADOOP-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139553#comment-18139553
]
ASF GitHub Bot commented on HADOOP-20015:
-----------------------------------------
hadoop-yetus commented on PR #8893:
URL: https://github.com/apache/hadoop/pull/8893#issuecomment-6682855009
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 29s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 1s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 0s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 10 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 1s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 27m 35s | | trunk passed |
| +1 :green_heart: | compile | 9m 42s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 9m 34s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 3m 19s | | trunk passed |
| +1 :green_heart: | mvnsite | 4m 23s | | trunk passed |
| +1 :green_heart: | javadoc | 3m 37s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 3m 31s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 5m 59s | | trunk passed |
| +1 :green_heart: | shadedclient | 17m 36s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 17s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 2m 45s | | the patch passed |
| +1 :green_heart: | compile | 9m 7s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 9m 7s | | the patch passed |
| +1 :green_heart: | compile | 9m 41s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 9m 41s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 3m 5s | | the patch passed |
| +1 :green_heart: | mvnsite | 4m 10s | | the patch passed |
| +1 :green_heart: | javadoc | 3m 44s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 3m 33s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 6m 55s | | the patch passed |
| +1 :green_heart: | shadedclient | 17m 38s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 17m 46s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | unit | 3m 4s | |
hadoop-yarn-server-applicationhistoryservice in the patch passed. |
| +1 :green_heart: | unit | 91m 47s | |
hadoop-yarn-server-resourcemanager in the patch passed. |
| +1 :green_heart: | unit | 23m 53s | | hadoop-yarn-server-nodemanager
in the patch passed. |
| +1 :green_heart: | unit | 25m 4s | | hadoop-yarn-client in the patch
passed. |
| +1 :green_heart: | asflicense | 0m 48s | | The patch does not
generate ASF License warnings. |
| | | 316m 57s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8893/11/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8893 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 847c2956affe 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 7610c8fd6446ad38eb33f3232f808d318f5422b4 |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8893/11/testReport/ |
| Max. process+thread count | 1304 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8893/11/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Stop using Jetty 9.4 APIs that Jetty 12 removes or the code does not need
> -------------------------------------------------------------------------
>
> Key: HADOOP-20015
> URL: https://issues.apache.org/jira/browse/HADOOP-20015
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Jose Luis López
> Assignee: Jose Luis López
> Priority: Major
> Labels: pull-request-available
>
> *Scope*: every use, in main and test code across the repository, of a Jetty
> 9.4 class that Jetty 12 no longer has, where the JDK, SLF4J or the servlet
> API does the same job:
> * FSMainOperationsBaseTest, ViewFileSystemTestSetup, ViewFsTestSetup,
> TestAuthenticationSessionCookie (hadoop-common),
> TestRollingLevelDBTimelineStore (applicationhistoryservice), TestAMRMClient,
> TestYarnCLI (yarn-client) and MockNM (resourcemanager): they logged through
> org.eclipse.jetty.util.log.Log, which Jetty 10 and later no longer have. Log
> through SLF4J instead.
> * TestDockerCommandExecutor (nodemanager): it borrowed a logger from Jetty's
> GzipHttpOutputInterceptor. Give it its own.
> * FederationInterceptor (nodemanager): replace Jetty's ConcurrentHashSet,
> which Jetty 12 no longer has, with ConcurrentHashMap.newKeySet().
> * TestLogAggregationService (nodemanager): it batched assertion failures in
> Jetty's MultiException, which Jetty 12 no longer has. Throw one
> org.opentest4j.MultipleFailuresError (which comes with junit-jupiter-api)
> with every failure, so each one's message is shown.
> * HttpServer2 (hadoop-common): it used Jetty's MultiException in start() and
> stop(). The start() catch only logged and rethrew into the outer catch
> (Exception e), which wraps it, so remove it; stop() collects its exceptions
> in a list instead, rethrowing a single one as it is and, with several, the
> first carrying the rest as suppressed exceptions. Also, drop the cast in
> inferMimeType to a Jetty context, since ServletContext has getMimeType.
> *Out of scope*: classes that Jetty 12 moves to the org.eclipse.jetty.ee8
> packages, and the Jetty types Jetty 12 removes with no replacement other than
> another Jetty API: RequestLogHandler, and
> WebSocketServlet/WebSocketServletFactory, which become
> ee8.websocket.server.JettyWebSocketServlet/JettyWebSocketServletFactory
> (HandlerCollection moves to ee8.nested and server.session.SessionHandler to
> org.eclipse.jetty.session). Those are the upgrade itself, HADOOP-19972.
> *Why*: these uses would not compile on Jetty 12, and none of them needs
> Jetty. Removing them now keeps HADOOP-19972 to the changes the upgrade really
> requires.
> *Impact on Jetty 9*: none. Java changes only, no pom change; the logging,
> set, failure-reporting, exception-collecting and MIME-type code behaves the
> same.
> *Downstream*: none.
> *CI*: hadoop-common, applicationhistoryservice, yarn-client, resourcemanager,
> nodemanager.
> *PR*: https://github.com/apache/hadoop/pull/8893
> Regrouped on 2026-11-04 by kind of change, as suggested in the review: this
> issue now holds all the Java changes that were split between HADOOP-20015
> (YARN) and HADOOP-20016 (HADOOP); HADOOP-20016 holds all the pom changes.
> Updated on 2026-11-05 with the review's follow-ups: HttpServer2's
> MultiException removed here rather than in HADOOP-19972, and the list of
> classes left to HADOOP-19972 corrected.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
