[
https://issues.apache.org/jira/browse/HADOOP-20072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18139985#comment-18139985
]
ASF GitHub Bot commented on HADOOP-20072:
-----------------------------------------
hadoop-yetus commented on PR #8957:
URL: https://github.com/apache/hadoop/pull/8957#issuecomment-6697853970
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 37s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to
include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 46m 35s | | trunk passed |
| +1 :green_heart: | compile | 16m 31s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 16m 49s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | checkstyle | 1m 33s | | trunk passed |
| +1 :green_heart: | mvnsite | 2m 1s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 31s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 27s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 11s | | trunk passed |
| +1 :green_heart: | shadedclient | 31m 43s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 1m 14s | | the patch passed |
| +1 :green_heart: | compile | 15m 47s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 15m 46s | | the patch passed |
| +1 :green_heart: | compile | 16m 48s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 16m 48s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | checkstyle | 1m 28s | | the patch passed |
| +1 :green_heart: | mvnsite | 2m 0s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 28s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 28s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | spotbugs | 3m 20s | | the patch passed |
| +1 :green_heart: | shadedclient | 31m 35s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 23m 41s | | hadoop-common in the patch
passed. |
| +1 :green_heart: | asflicense | 1m 17s | | The patch does not
generate ASF License warnings. |
| | | 223m 47s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8957/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8957 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets |
| uname | Linux 269096c875e3 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 1cd43506fc7eb047f4c3911a569225f100d7585a |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8957/1/testReport/ |
| Max. process+thread count | 1296 (vs. ulimit of 10000) |
| modules | C: hadoop-common-project/hadoop-common U:
hadoop-common-project/hadoop-common |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8957/1/console |
| versions | git=2.43.0 maven=3.9.15 spotbugs=4.9.7 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> TableMapping never matches IPv6 entries written in compressed form
> ------------------------------------------------------------------
>
> Key: HADOOP-20072
> URL: https://issues.apache.org/jira/browse/HADOOP-20072
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: net
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
>
> {{CachedDNSToSwitchMapping#resolve}} normalizes every name with
> {{NetUtils.normalizeHostName}}, which returns {{InetAddress#getHostAddress}}.
> For IPv6 that is the full form without zero compression, for example
> {{2001:db8:0:0:0:0:0:10}}. {{TableMapping}} then looks the name up with an
> exact string match ({{RawTableMapping#resolve}}), and its keys are kept
> exactly as written in the table file.
> So an entry in the usual compressed form ([RFC
> 5952|https://datatracker.ietf.org/doc/html/rfc5952]), such as
> {{2001:db8::10}}, never matches, whichever form the caller passes. The node
> quietly falls back to {{/default-rack}}. Only the full form works.
> h3. Reproduction (3.4.3)
> Table file:
> {noformat}
> 2001:db8::10 /rack1
> 10.0.0.5 /rack2
> {noformat}
> {code:java}
> tableMapping.resolve(Arrays.asList("2001:db8::10", "2001:db8:0:0:0:0:0:10",
> "10.0.0.5"));
> // [/default-rack, /default-rack, /rack2]
> {code}
> With {{2001:db8:0:0:0:0:0:10 /rack1}} in the file instead, the first two
> resolve to {{/rack1}}.
> h3. Impact
> Rack awareness for nodes registered by IPv6 address: HDFS datanodes, and
> Ozone datanodes and clients (SCM and OM resolve through the same mapping).
> {{ScriptBasedMapping}} passes the same full form to the topology script, so
> scripts have to expect it too.
> h3. Proposal
> When loading the table in {{RawTableMapping#load}}, normalize keys that are
> IP literals to the same form the lookup uses (for example
> {{InetAddresses.forString(key).getHostAddress()}}), without DNS lookups.
> Leave other keys as they are. Add a test with compressed and full-form IPv6
> entries.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
