[
https://issues.apache.org/jira/browse/HADOOP-20008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18140021#comment-18140021
]
ASF GitHub Bot commented on HADOOP-20008:
-----------------------------------------
hadoop-yetus commented on PR #8950:
URL: https://github.com/apache/hadoop/pull/8950#issuecomment-6699346454
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 57s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files
found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +0 :ok: | detsecrets | 0m 1s | | detect-secrets was not available.
|
| +0 :ok: | xmllint | 0m 1s | | xmllint was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain
any @author tags. |
| -1 :x: | test4tests | 0m 0s | | The patch doesn't appear to include
any new or modified tests. Please justify why no new tests are needed for this
patch. Also please list what manual steps were performed to verify this patch.
|
|||| _ trunk Compile Tests _ |
| +0 :ok: | mvndep | 2m 10s | | Maven dependency ordering for branch |
| +1 :green_heart: | mvninstall | 52m 47s | | trunk passed |
| +1 :green_heart: | compile | 17m 55s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | compile | 18m 35s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | mvnsite | 1m 52s | | trunk passed |
| +1 :green_heart: | javadoc | 1m 36s | | trunk passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 29s | | trunk passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 131m 59s | | branch has no errors
when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +0 :ok: | mvndep | 0m 38s | | Maven dependency ordering for patch |
| +1 :green_heart: | mvninstall | 0m 54s | | the patch passed |
| +1 :green_heart: | compile | 16m 58s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javac | 16m 58s | | the patch passed |
| +1 :green_heart: | compile | 18m 18s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | javac | 18m 18s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks
issues. |
| +1 :green_heart: | mvnsite | 1m 48s | | the patch passed |
| +1 :green_heart: | javadoc | 1m 29s | | the patch passed with JDK
Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu |
| +1 :green_heart: | javadoc | 1m 29s | | the patch passed with JDK
Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| +1 :green_heart: | shadedclient | 42m 54s | | patch has no errors
when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 0m 41s | | hadoop-project in the patch
passed. |
| +1 :green_heart: | unit | 1m 22s | |
hadoop-yarn-applications-catalog-webapp in the patch passed. |
| +1 :green_heart: | asflicense | 1m 13s | | The patch does not
generate ASF License warnings. |
| | | 218m 32s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.56 ServerAPI=1.56 base:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8950/2/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/8950 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient codespell detsecrets xmllint |
| uname | Linux af788d2bc59e 5.15.0-190-generic #200-Ubuntu SMP Fri Aug 7
15:06:04 UTC 2026 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / e291737135009eb60fa69a7a67f5c62bad2b380c |
| Default Java | Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Multi-JDK versions |
/usr/lib/jvm/java-21-openjdk-amd64:Ubuntu-21.0.12.1+1-1-24.04.4-Ubuntu
/usr/lib/jvm/java-17-openjdk-amd64:Ubuntu-17.0.20.1+1-1-24.04-Ubuntu |
| Test Results |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8950/2/testReport/ |
| Max. process+thread count | 572 (vs. ulimit of 10000) |
| modules | C: hadoop-project
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
U: . |
| Console output |
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8950/2/console |
| versions | git=2.43.0 maven=3.9.15 |
| Powered by | Apache Yetus 0.14.1 https://yetus.apache.org |
This message was automatically generated.
> Give the YARN application catalog its own Jetty version; drop the unused
> solr-test-framework
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-20008
> URL: https://issues.apache.org/jira/browse/HADOOP-20008
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: build, yarn
> Reporter: Jose Luis López
> Priority: Minor
> Labels: pull-request-available
>
> hadoop-yarn-applications-catalog-webapp embeds Solr 8.11.2, which is compiled
> against Jetty 9.4. It needs Jetty even without a container:
> {{EmbeddedSolrServer}}'s constructor loads {{HttpShardHandlerFactory}}, which
> uses the Jetty 9.4 HTTP client. Today that works because Hadoop is on 9.4
> too. Once HADOOP-19972 moves Hadoop to Jetty 12, the two cannot share the
> module's classpath, because they share jetty-http, jetty-io and jetty-util.
> This change decouples the module first, so the upgrade only has to bump
> Hadoop's own version.
> h3. Changes
> * New {{solr.jetty.version}} in the root pom, set to the release trunk ships
> today, 9.4.58.v20250814. Solr 8.11.2 was built against 9.4.44, but nothing
> needs that release.
> * The webapp's pom gets a local {{dependencyManagement}} that overrides the
> inherited {{jetty.version}} pin and imports the jetty-bom of the same
> release. That way all of Solr's Jetty, including solr-core's server side and
> http2, resolves to one 9.4 release.
> * Follow-up to HADOOP-20012 noted by [~pjfanning]: the tests import
> {{EmbeddedSolrServer}} (solrj) and {{NodeConfig}} (solr-core) and nothing
> from solr-test-framework, so the framework dependency and its exclusion list
> are dropped. {{solr-core}} keeps the single exclusion list, and the test
> classpath stops pulling in ant, junit4-ant, hamcrest-core, junit,
> lucene-test-framework, opentracing-mock and randomizedtesting-runner.
> h3. Compatibility
> No change: app.war ships the same Jetty as today.
> HADOOP-19998, which moves the catalog off Solr 8, later removes this pin.
--
This message was sent by Atlassian Jira
(v10.3.26#10030026)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
