pjfanning commented on code in PR #8890:
URL: https://github.com/apache/hadoop/pull/8890#discussion_r4496810389
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml:
##########
@@ -160,9 +160,16 @@
</exclusions>
</dependency>
+ <!--
+ The tests reach Solr only through EmbeddedSolrServer, which runs no
+ servlet container. solr-test-framework brings solr-core, where
+ EmbeddedSolrServer lives, so it is the only Solr test dependency and
+ the one place that excludes Solr's own Jetty (9.4.44) and servlet
API:
+ the test classpath keeps only ${jetty.version}.
+ -->
<dependency>
<groupId>org.apache.solr</groupId>
- <artifactId>solr-core</artifactId>
+ <artifactId>solr-test-framework</artifactId>
Review Comment:
Non-blocking nit: the tests import `EmbeddedSolrServer` and `NodeConfig`
from `solr-core` and nothing from `solr-test-framework`. Keeping `solr-core`
and dropping the framework would give the same single exclusion list with fewer
test jars, since the framework only adds `solr-core` itself plus `ant`,
`hamcrest-core`, `junit`, `junit4-ant`, `lucene-test-framework`,
`opentracing-mock` and `randomizedtesting-runner`. Fine to leave as is or
handle in a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
