pan3793 commented on PR #8894: URL: https://github.com/apache/hadoop/pull/8894#issuecomment-6621102120
> Declare jetty-http where it is imported, and drop Jetty's Log and context cast I think it's two topics, though both are small enough that I don't worry about mixing them in one PR. +1 for the latter, but I'm not sure about the intention of the former; I know someone calls that best practice, but it seems your purpose is to make the version alignment? If so, I would not do it in this way, we should pin the version in parent pom.xml `dependencyManagement` so that all sub-modules use the same version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
