luoyuan3471 commented on code in PR #8854:
URL: https://github.com/apache/hadoop/pull/8854#discussion_r4511385446
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/ClientRMService.java:
##########
@@ -512,11 +512,14 @@ public GetContainerReportResponse getContainerReport(
ApplicationAccessType.VIEW_APP, application);
GetContainerReportResponse response = null;
if (allowAccess) {
- RMAppAttempt appAttempt = application.getAppAttempts().get(appAttemptId);
- if (appAttempt == null) {
- throw new ApplicationAttemptNotFoundException(
- "ApplicationAttempt with id '" + appAttemptId +
- "' doesn't exist in RM.");
+ if (!application.getApplicationSubmissionContext()
Review Comment:
Thanks for pointing out the behavior change. I've updated the PR and Jira
descriptions to clarify that a missing attempt and container now produce
ContainerNotFoundException instead of ApplicationAttemptNotFoundException. I've
also renamed the test so it no longer implies that the previous behavior is
preserved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
