anmolanmol1234 commented on code in PR #8830:
URL: https://github.com/apache/hadoop/pull/8830#discussion_r4522386872
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/ReadBufferManagerV2.java:
##########
@@ -632,7 +750,14 @@ public void doneReading(final ReadBuffer buffer,
buffer.setStatus(ReadBufferStatus.AVAILABLE);
buffer.setLength(bytesActuallyRead);
}
+ if(parentBuffer != null) {
+ parentBuffer.decrementActiveChildren();
+ }
} else {
+ // If a child buffer, then reset the active child count to 0 in
parent buffer
+ if (parentBuffer != null) {
+ parentBuffer.resetActiveChildCount();
Review Comment:
If one child read fails while other children are still running, we reset the
active child count and return the shared buffer index to the free list. Could
another read reuse this buffer while the remaining children are still writing
to it? Should we wait for all children to complete before releasing the shared
buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
