anmolanmol1234 commented on code in PR #8830: URL: https://github.com/apache/hadoop/pull/8830#discussion_r4523891109
########## hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/services/TestAbfsInputStream.java: ########## @@ -83,6 +111,8 @@ import static org.apache.hadoop.fs.azurebfs.constants.ReadType.PREFETCH_READ; import static org.apache.hadoop.fs.azurebfs.constants.ReadType.RANDOM_READ; import static org.apache.hadoop.fs.azurebfs.constants.ReadType.SMALLFILE_READ; +import static org.assertj.core.api.Assumptions.assumeThat; +import static org.assertj.core.api.Assertions.assertThat; Review Comment: There are no regression tests for the multi-child failure paths. Please add tests for partial layout coverage in a read-ahead window, one child failing while siblings are in flight, and eviction freeing the shared index exactly once. The @Order(Integer.MAX_VALUE) workaround suggests shared-state leakage between tests, so please fix the leak. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
