[
https://issues.apache.org/jira/browse/HADOOP-8630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426753#comment-13426753
]
Steve Loughran commented on HADOOP-8630:
----------------------------------------
# that patch does a complete file replace; looks like CRLF grief, which I've
encountered myself regularly.
# can you grab the github fork I linked to and use that as a starting point as
I did a bit more changes, including renaming the (new) base class. It needs
more review and a test run, but I think it's effectively a superset of your
patch.
-steve
> rename isSingleSwitch() methods in new topo base class to isFlatTopology()
> --------------------------------------------------------------------------
>
> Key: HADOOP-8630
> URL: https://issues.apache.org/jira/browse/HADOOP-8630
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Steve Loughran
> Priority: Trivial
> Attachments: HADOOP-8630.patch
>
> Original Estimate: 0.5h
> Remaining Estimate: 0.5h
>
> The new topology logic that is not yet turned on in HDFS uses the method
> {{isSingleSwitch()}} for implementations to declare whether or not they are
> single switch.
> The use of "switch" is an implementation issue; the big VM-based patch shows
> that really it's about "flat" vs "hierarchical", with Hadoop assuming that
> subtrees in the hierarchy have better bandwidth (good) but correlated
> failures (bad).
> Renaming the method now -before it's fixed and used- is time time to do it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
