[
https://issues.apache.org/jira/browse/HADOOP-8649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429259#comment-13429259
]
Karthik Kambatla commented on HADOOP-8649:
------------------------------------------
Thanks for the review, Daryn. Great points, I have missed them.
bq. I question the null check, although useful, because FileSystems doesn't
allow a null filter. This would make a FilterFileSystem behave differently.
FileSystem itself should probably be changed to ignore a null since it appears
to cause a NPE.
Agree. FileSystem should check for null. However, I believe ChecksumFileSystem
should also check for a null, otherwise the joinFilter would be non-null and
have a constituent null filter.
Fixed the invocation order - will upload the new patch soon.
> ChecksumFileSystem should have an overriding implementation of
> listStatus(Path, PathFilter)
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-8649
> URL: https://issues.apache.org/jira/browse/HADOOP-8649
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Attachments: HADOOP-8649_branch1.patch
>
>
> Currently, ChecksumFileSystem implements only listStatus(Path). The other
> form of listStatus(Path, PathFilter) is implemented by parent class
> FileSystem, and hence doesn't filter out check-sum files.
> The implementation should use a composite filter of passed Filter and the
> Checksum filter.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
