[ 
https://issues.apache.org/jira/browse/HADOOP-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13429440#comment-13429440
 ] 

Suresh Srinivas commented on HADOOP-8581:
-----------------------------------------

Early comments.

I prefer splitting this into separate patches instead of one single patch that 
Jenkins cannot use.
# There are unnecessary white space changes (e.g: WebAppProxyServlet.java). 
Indentation in some places is incorrect as well (4 spaces instead of two 
spaces).
# core-site.xml - typo "SSL for for the HTTP". Can you please add more/better 
description for the new parameter added.
# HttpServer. java - please do not turn checked exception 
GeneralSecurityException into RTE. Perhaps you could throw it as IOException
# Add brief comments to TestSSLHttpServer.java
# Not sure you needed to make getTaskLogsUrl() non-static

                
> add support for HTTPS to the web UIs
> ------------------------------------
>
>                 Key: HADOOP-8581
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8581
>             Project: Hadoop Common
>          Issue Type: New Feature
>          Components: security
>    Affects Versions: 2.0.0-alpha
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 2.1.0-alpha
>
>         Attachments: HADOOP-8581.patch
>
>
> HDFS/MR web UIs don't work over HTTPS, there are places where 'http://' is 
> hardcoded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to