[
https://issues.apache.org/jira/browse/HADOOP-8700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435167#comment-13435167
]
Hadoop QA commented on HADOOP-8700:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541027/c8700_20120815.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified test
files.
-1 javac. The patch appears to cause the build to fail.
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1306//console
This message is automatically generated.
> Move the checksum type constants to an enum
> -------------------------------------------
>
> Key: HADOOP-8700
> URL: https://issues.apache.org/jira/browse/HADOOP-8700
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Priority: Minor
> Attachments: c8700_20120815.patch
>
>
> In DataChecksum, there are constants for crc types, crc names and crc sizes.
> We should move them to an enum for better coding style.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira