[
https://issues.apache.org/jira/browse/HADOOP-8707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436146#comment-13436146
]
Steve Loughran commented on HADOOP-8707:
----------------------------------------
# there's no obvious place for it to close unless MetricsSink added a close
method that was called on shutdown.
# the {{FileSink}} would need to differentiate {{System.out}} from streams it
should not close, either explicitly or by some {{Writer}} subclass that didn't
relay {{close()}} methods.
If someone really wanted to use {{FileSink}} in production, the class should be
set up to close the file on a {{flush()}} and re-open with an append on demand.
> FileSink doesn't appear to close its file
> -----------------------------------------
>
> Key: HADOOP-8707
> URL: https://issues.apache.org/jira/browse/HADOOP-8707
> Project: Hadoop Common
> Issue Type: Bug
> Components: metrics
> Affects Versions: 1.0.3
> Reporter: Steve Loughran
> Priority: Minor
>
> Looking at FileSink, I can see it opening a fileWriter in the {{init()}}
> method, but it never closes it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
