[
https://issues.apache.org/jira/browse/HADOOP-8239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438409#comment-13438409
]
Tsz Wo (Nicholas), SZE commented on HADOOP-8239:
------------------------------------------------
Hi Kihwal,
Forgot to add the new files? The new classes are not found in the patch.
The previous Jenkins build did not test your patch. It seems that it failed to
download the patch file. The patch file shown in Build Artifacts had zero
byte. However, Jenkins still ran the build as usually. I filed HADOOP-8714
for this problem.
I looked at your previous two patches. Some comments:
- DataChecksum.MIXED is not used. What do we need it? Could we add it later?
- MD5MD5CRC32GzipFileChecksum and MD5MD5CRC32CastagnoliFileChecksum should not
have the following fields.
{code}
+ private int bytesPerCRC;
+ private long crcPerBlock;
+ private MD5Hash md5;
{code}
They should use the fields in the super class. Also the constructors should
call the super class constructors.
> Extend MD5MD5CRC32FileChecksum to show the actual checksum type being used
> --------------------------------------------------------------------------
>
> Key: HADOOP-8239
> URL: https://issues.apache.org/jira/browse/HADOOP-8239
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Reporter: Kihwal Lee
> Assignee: Kihwal Lee
> Fix For: 2.1.0-alpha
>
> Attachments: hadoop-8239-after-hadoop-8240.patch.txt,
> hadoop-8239-after-hadoop-8240.patch.txt,
> hadoop-8239-before-hadoop-8240.patch.txt,
> hadoop-8239-before-hadoop-8240.patch.txt,
> hadoop-8239-trunk-branch2.patch.txt, hadoop-8239-trunk-branch2.patch.txt
>
>
> In order to support HADOOP-8060, MD5MD5CRC32FileChecksum needs to be extended
> to carry the information on the actual checksum type being used. The
> interoperability between the extended version and branch-1 should be
> guaranteed when Filesystem.getFileChecksum() is called over hftp, webhdfs or
> httpfs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
