[ 
https://issues.apache.org/jira/browse/HADOOP-8723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440546#comment-13440546
 ] 

Hadoop QA commented on HADOOP-8723:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542157/HADOOP-8723.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) 
warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed unit tests in hadoop-assemblies.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1354//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1354//console

This message is automatically generated.
                
> Remove tests and tests-sources jars from classpath
> --------------------------------------------------
>
>                 Key: HADOOP-8723
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8723
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.0-alpha
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>         Attachments: HADOOP-8723.patch
>
>
> Currently {{hadoop-config.sh}} is including any tests and tests-sources jars 
> in the default classpath, as those jars are shipped in the dist tarball next 
> to the main jars and the script is globbing everything in that directory.
> The tests and tests-sources jars aren't required to run Hadoop, but they can 
> cause breakage when inadvertently picked up.  See HDFS-3831 as an example.  
> Ideally we should not be adding these jars to the classpath.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to