[
https://issues.apache.org/jira/browse/HADOOP-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442239#comment-13442239
]
Harsh J commented on HADOOP-8728:
---------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
Existing tests should cover this change already, but if needed I can add in a
JavaSerialization based test.
{quote}
-1 core tests. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
{quote}
This seems unrelated to the patch changes here.
> Display (fs -text) shouldn't hard-depend on Writable serialized sequence
> files.
> -------------------------------------------------------------------------------
>
> Key: HADOOP-8728
> URL: https://issues.apache.org/jira/browse/HADOOP-8728
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.0.0-alpha
> Reporter: Harsh J
> Priority: Minor
> Attachments: HADOOP-8728.patch
>
>
> The Display command (fs -text) currently reads only Writable-based
> SequenceFiles. This isn't necessary to do, and prevents reading
> non-Writable-based serialization in SequenceFiles from the shell.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
