[ 
https://issues.apache.org/jira/browse/HADOOP-8657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442823#comment-13442823
 ] 

Bikas Saha commented on HADOOP-8657:
------------------------------------

The test was failing because it was checking for file sizes on disk and the 
sizes were hardcoded in the test. text file sizes can be different on different 
platforms based on character encodings etc. The fix was to read the actual file 
size from disk and then check values based on that instead of some hardcoded 
value. The test files are actually checked into the source as resources. 
Ideally, the test would generate these files on the fly instead of checking 
them in but I am leaving that re-organization of the code tree for later when 
the branch is merged back so as to simplify the merge.
                
> TestCLI fails on Windows because it uses hardcoded file length of test files 
> committed to the source code
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8657
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8657
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Bikas Saha
>            Assignee: Bikas Saha
>         Attachments: HADOOP-8657.branch-1-win.1.patch
>
>
> The actual length of the file would depend on the character encoding used and 
> hence cannot be hard-coded.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to