[ 
https://issues.apache.org/jira/browse/HADOOP-8160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443595#comment-13443595
 ] 

Brandon Li commented on HADOOP-8160:
------------------------------------

I am so sorry that, after double checking the patch, I got a couple more 
comments.
1. it would be nice to have a method to convert DOS path to CygWin path, and 
have a unit test to just test the conversion.
2. can you document in the code why using another thread to getLinkCount? 
                
> HardLink.getLinkCount() is getting stuck in eclipse ( Cygwin) for long file 
> names, due to MS-Dos style Path.
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8160
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8160
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.23.1, 0.24.0
>         Environment: Cygwin
>            Reporter: Vinay
>            Assignee: Vinay
>            Priority: Minor
>             Fix For: 2.1.0-alpha, 3.0.0
>
>         Attachments: HADOOP-8160.patch
>
>   Original Estimate: 2m
>  Remaining Estimate: 2m
>
> HardLink.getLinkCount() is getting stuck in cygwin for long file names, due 
> to MS-DOS style path.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to