[
https://issues.apache.org/jira/browse/HADOOP-8736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444515#comment-13444515
]
Brandon Li commented on HADOOP-8736:
------------------------------------
{quote}build() method, please follow the coding guidelines and have {} after
if.{quote}
done
{quote}Throwing HadoopIllegalArgumentException is fine. But if you are doing
that for two of the parameters, I suggest doing the same for handlerCount and
conf parameter as well.{quote}
Done for conf, handlerCount has a default as "1".
{quote} In javadoc for build() method please add @throws and say if mandator
fields are not set, the build method will throw
HadoopIllegalArgumentException.{quote}
Done.
{quote} Please add a testcase where you create RPC server without mandatory
fields and ensure exceptions are thrown. We could perhaps add this to
TestIPC.{quote}
Done in TestRPC.java.
> Create a Builder to make an RPC server
> --------------------------------------
>
> Key: HADOOP-8736
> URL: https://issues.apache.org/jira/browse/HADOOP-8736
> Project: Hadoop Common
> Issue Type: Improvement
> Components: ipc
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HADOOP-8736.patch, HADOOP-8736.patch, HADOOP-8736.patch
>
>
> There are quite a few variants of getServer() method to create an RPC server.
> Create a builder class to abstract the building steps and avoid more
> getServer() variants in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
