[ https://issues.apache.org/jira/browse/HADOOP-8616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451140#comment-13451140 ]
Aaron T. Myers commented on HADOOP-8616: ---------------------------------------- The patch looks pretty good to me. Two little comments: # I'd recommend using {{String#isEmpty()}} instead of {{String#length() == 0}}. # Does a similar change not need to be made to the FileContext side of the house, i.e. ChRootedFs? > ViewFS configuration requires a trailing slash > ---------------------------------------------- > > Key: HADOOP-8616 > URL: https://issues.apache.org/jira/browse/HADOOP-8616 > Project: Hadoop Common > Issue Type: Bug > Components: viewfs > Affects Versions: 0.23.0, 2.0.0-alpha > Reporter: Eli Collins > Assignee: Sandy Ryza > Attachments: HADOOP-8616.patch > > > If the viewfs config doesn't have a trailing slash commands like the > following fail: > {noformat} > bash-3.2$ hadoop fs -ls > -ls: Can not create a Path from an empty string > Usage: hadoop fs [generic options] -ls [-d] [-h] [-R] [<path> ...] > {noformat} > We hit this problem with the following configuration because > "hdfs://ha-nn-uri" does not have a trailing "/". > {noformat} > <property> > <name>fs.viewfs.mounttable.foo.link./nameservices/ha-nn-uri</name> > <value>hdfs://ha-nn-uri</value> > </property> > {noformat} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira