[
https://issues.apache.org/jira/browse/HADOOP-8476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453400#comment-13453400
]
Arpit Gupta commented on HADOOP-8476:
-------------------------------------
Vinay could you regenerate the patch, it does not apply on trunk.
Also some comments/questions based on your patch file
You have added an option to the hadoop-config.sh script to skip hadoop opts
"--skip_hadoop_opts" and you are passing that in all the various places
hadoop-config.sh is called and this skipping the setting of HADOOP_OPTS.
I dont think we should make the assumption that people will have the
appropriate values set in the env by the hadoop-env.sh config file. People
change this config based on what their needs are and we cannot force them to
have all of these defined. hadoop-config.sh made sure certain defaults are set.
> Remove duplicate VM arguments for hadoop deamon
> -----------------------------------------------
>
> Key: HADOOP-8476
> URL: https://issues.apache.org/jira/browse/HADOOP-8476
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 2.0.0-alpha, 3.0.0
> Reporter: Vinay
> Assignee: Vinay
> Priority: Minor
> Attachments: HADOOP-8476.patch, HADOOP-8476.patch
>
>
> remove duplicate VM arguments passed to hadoop daemon
> Following are the VM arguments currently duplicated.
> {noformat}-Dproc_namenode
> -Xmx1000m
> -Djava.net.preferIPv4Stack=true
> -Xmx128m
> -Xmx128m
> -Dhadoop.log.dir=/home/nn2/logs
> -Dhadoop.log.file=hadoop-root-namenode-HOST-xx-xx-xx-105.log
> -Dhadoop.home.dir=/home/nn2/
> -Dhadoop.id.str=root
> -Dhadoop.root.logger=INFO,RFA
> -Dhadoop.policy.file=hadoop-policy.xml
> -Djava.net.preferIPv4Stack=true
> -Dhadoop.security.logger=INFO,RFAS
> -Dhdfs.audit.logger=INFO,NullAppender
> -Dhadoop.security.logger=INFO,RFAS
> -Dhdfs.audit.logger=INFO,NullAppender
> -Dhadoop.security.logger=INFO,RFAS
> -Dhdfs.audit.logger=INFO,NullAppender
> -Dhadoop.security.logger=INFO,RFAS{noformat}
>
> In above VM argumants -Xmx1000m will be Overridden by -Xmx128m.
> BTW Other duplicate arguments wont harm
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
