[ 
https://issues.apache.org/jira/browse/HADOOP-8755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454171#comment-13454171
 ] 

Andrey Klochkov commented on HADOOP-8755:
-----------------------------------------

Hi Aaron, I'd like to make number of improvements before submitting a patch. 
These are:
# include dead lock detection into the dump
# introduce default timeouts on junit level

The 2nd one is not easy. I'm thinking about 2 possible ways to implement it, 
and both seem pretty hackie. The first is implementing a custom Surefire 
provider. It's not straightforward (if possible) as there are no explicit 
extension points for that in Surefire.  The second is doing instrumentation 
with a custom JVM agent, adding "timeout" parameter to the @Test annotation for 
all test methods which don't provide it. I'm planning to evaluate both ways but 
it may take time. I think a separate JIRA would be better for this part. WDYT?
                
> Print thread dump when tests fail due to timeout 
> -------------------------------------------------
>
>                 Key: HADOOP-8755
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8755
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 1.0.3, 0.23.1, 2.0.0-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HDFS-3762-branch-0.23.patch, HDFS-3762.patch, 
> HDFS-3762.patch, HDFS-3762.patch, HDFS-3762.patch, HDFS-3762.patch
>
>
> When a test fails due to timeout it's often not clear what is the root cause. 
> See HDFS-3364 as an example.
> We can print dump of all threads in this case, this may help finding causes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to