[
https://issues.apache.org/jira/browse/HADOOP-8801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13455822#comment-13455822
]
Steve Loughran commented on HADOOP-8801:
----------------------------------------
@Eli, this patch went in within 2 hours of being submitted. This effectively
prevented any review from anyone not in PST timezone keeping up to date with
their JIRA issues.
While I celebrate a rapid integration of patches into the tree, I believe this
devalues the RTC process, as people like myself can't review, even though -as I
did belatedly comment- the patch should use {{toString()}} over
{{getMessage()}}, because {{getMessage()}} has the right to return null.
# I think this a bad precedent. It means there's nothing to stop me getting
together with someone else in the EU and pushing through a set of changes
before anyone notices.
# As I said, the patch is inadequate.
I don't want to revert the patch -it's in- but I'd like my feedback to be
incorporated into a new JIRA, as {{s/getMessage()/r/toString()}} enhances the
value of the output even more.
Do you want to do this? Or shall I? And in either case, can we have slightly
more than 2h for review?
> ExitUtil#terminate should capture the exception stack trace
> -----------------------------------------------------------
>
> Key: HADOOP-8801
> URL: https://issues.apache.org/jira/browse/HADOOP-8801
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 2.0.2-alpha
>
> Attachments: hadoop-8801.txt
>
>
> ExitUtil#terminate(status,Throwable) should capture and log the stack trace
> of the given throwable. This will help debug issues like HDFS-3933.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
