[ 
https://issues.apache.org/jira/browse/HADOOP-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456739#comment-13456739
 ] 

Suresh Srinivas commented on HADOOP-8819:
-----------------------------------------

bq. Note that the change in FTPFileSystem actually is a behavior change, and 
perhaps an incompatible one. All of the rest of these changes seem harmless, 
but that one seems a little suspect.


{noformat}
      if (created) {
        String parentDir = parent.toUri().getPath();
        client.changeWorkingDirectory(parentDir);
        created = created && client.makeDirectory(pathName);
      }
{noformat}

In this code if {{created}} is true it enters the if condition and then 
executes client.makeDirectory(). If {{created}} is false that part of the code 
is not entered.

Aaron, can you add details on why this would change the behavior? 
                
> Should use && instead of  & in a few places in 
> FTPFileSystem,FTPInputStream,S3InputStream,ViewFileSystem,ViewFs
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8819
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8819
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8819.patch
>
>
> Should use && instead of  & in a few places in 
> FTPFileSystem,FTPInputStream,S3InputStream,ViewFileSystem,ViewFs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to