[ 
https://issues.apache.org/jira/browse/HADOOP-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458782#comment-13458782
 ] 

Suresh Srinivas edited comment on HADOOP-8805 at 9/20/12 3:06 AM:
------------------------------------------------------------------

bq. @suresh, sorry, seen your comment after I've done the commit/posted the 
commit comment.
No problem. I will review the patch sometime this week and post the comments, 
if there are any.

bq. We should open a JIRA to normalize package/classes names for all the proto 
stuff across common/hdfs/yarn/mapred, would you do that giving examples of the 
diff namings being used at the moment? 
I disagree with this. HDFS and YARN use different mechanism inheritance vs 
translation in protobuf implementation. I would just leave the implementations 
as they are. I do not think there is a need to normalize this stuff across 
different sub-projects.
                
      was (Author: sureshms):
    bq. @suresh, sorry, seen your comment after I've done the commit/posted the 
commit comment.
No problem. I review the patch sometime this week and post the comments, if 
there are any.

bq. We should open a JIRA to normalize package/classes names for all the proto 
stuff across common/hdfs/yarn/mapred, would you do that giving examples of the 
diff namings being used at the moment? 
I disagree with this. HDFS and YARN use different mechanism inheritance vs 
translation in protobuf implementation. I would just leave the implementations 
as they are. I do not think there is a need to normalize this stuff across 
different sub-projects.
                  
> Move protocol buffer implementation of GetUserMappingProtocol from HDFS to 
> Common
> ---------------------------------------------------------------------------------
>
>                 Key: HADOOP-8805
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8805
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Bo Wang
>            Assignee: Bo Wang
>             Fix For: 2.0.3-alpha
>
>         Attachments: HADOOP-8805.patch, HADOOP-8805-v2.patch, 
> HADOOP-8805-v3.patch
>
>
> org.apache.hadoop.tools.GetUserMappingProtocol is used in both HDFS and YARN. 
> We should move the protocol buffer implementation from HDFS to Common so that 
> it can also be used by YARN.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to