[
https://issues.apache.org/jira/browse/HADOOP-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459128#comment-13459128
]
Jason Lowe commented on HADOOP-8822:
------------------------------------
Looks good overall, couple of minor comments:
* I suspect Python provides a built-in way to quote/escape HTML rather than
having us do it manually in the script
* dictUnion(a,b) can be written as {{dict(b, **a)}} or if you prefer, {{ret =
dict(b); ret.update(a)}}
* List comprehension syntax could simplify a lot of the small for loops, e.g.:
strs = [ str(p) for p in self.parts ]. This is more of a style thing, some
people are averse to the list comprehension syntax.
> relnotes.py was deleted post mavenization
> -----------------------------------------
>
> Key: HADOOP-8822
> URL: https://issues.apache.org/jira/browse/HADOOP-8822
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 0.23.3
> Reporter: Robert Joseph Evans
> Assignee: Robert Joseph Evans
> Attachments: HADOOP-8822.txt, HADOOP-8822.txt, HADOOP-8822.txt,
> HADOOP-8822.txt
>
>
> relnotes.py was removed post mavinization. It needs to be added back in so
> we can generate release notes, and it should be updated to deal with YARN and
> the separate release notes files.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
