[
https://issues.apache.org/jira/browse/HADOOP-8174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461102#comment-13461102
]
Hadoop QA commented on HADOOP-8174:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12546157/HADOOP-8174.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed these unit tests in
hadoop-common-project/hadoop-common:
org.apache.hadoop.ha.TestZKFailoverController
org.apache.hadoop.metrics2.impl.TestMetricsSystemImpl
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1496//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/1496//console
This message is automatically generated.
> Remove confusing comment in Path#isAbsolute()
> ---------------------------------------------
>
> Key: HADOOP-8174
> URL: https://issues.apache.org/jira/browse/HADOOP-8174
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 0.23.0
> Reporter: Suresh Srinivas
> Assignee: Suresh Srinivas
> Attachments: HADOOP-8174.patch, HADOOP-8174.txt
>
>
> The method is checking for absolute path correctly. When scheme and authority
> are present, the path is absolute. So the following comment needs to be
> removed.
> {noformat}
> /**
> * There is some ambiguity here. An absolute path is a slash
> * relative name without a scheme or an authority.
> * So either this method was incorrectly named or its
> * implementation is incorrect. This method returns true
> * even if there is a scheme and authority.
> */
> {noformat}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
