[ 
https://issues.apache.org/jira/browse/HADOOP-8776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462436#comment-13462436
 ] 

Hemanth Yamijala commented on HADOOP-8776:
------------------------------------------

Hi Colin, Thanks for your comments. I guess what you're suggesting is to not 
disable the compile of native code by default. But instead, provide a switch to 
not compile native code if required. Ultimately when HADOOP-8744 is fixed, 
contributors can just stop using the flag.

My rationale for this JIRA is that without an option like this, we are actually 
preventing (some) contributors from testing *anything* locally because 
test-patch simply fails. For the same reason, I made the default option to 
switch off native compile. 

One thing we could do is to enable native compile by default, but print a 
message hinting to use the disable flag in case compile failed in test-patch. I 
will work on that and provide a new patch. 
                
> Provide an option in test-patch that can enable / disable compiling native 
> code
> -------------------------------------------------------------------------------
>
>                 Key: HADOOP-8776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8776
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>            Reporter: Hemanth Yamijala
>            Assignee: Hemanth Yamijala
>            Priority: Minor
>         Attachments: HADOOP-8776.patch
>
>
> The test-patch script in Hadoop source runs a native compile with the patch. 
> On platforms like MAC, there are issues with the native compile that make it 
> difficult to use test-patch. This JIRA is to try and provide an option to 
> make the native compilation optional.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to