[ 
https://issues.apache.org/jira/browse/HADOOP-8855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464258#comment-13464258
 ] 

Eli Collins commented on HADOOP-8855:
-------------------------------------

+1, patch and testing look good - modulo two small things:

Nits:
- openSecureHttpConnection javadoc shouldn't mention SPNEGO only since there 
are other authenticators
- Think you mean to remove this debug statement
{code}
   private void sendToken(byte[] outToken) throws IOException, 
AuthenticationException {
+    new Exception("sendToken").printStackTrace(System.out);
{code}
                
> SSL-based image transfer does not work when Kerberos is disabled
> ----------------------------------------------------------------
>
>                 Key: HADOOP-8855
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8855
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 3.0.0, 2.0.2-alpha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hadoop-8855.txt, hadoop-8855.txt, hadoop-8855.txt
>
>
> In SecurityUtil.openSecureHttpConnection, we first check 
> {{UserGroupInformation.isSecurityEnabled()}}. However, this only checks the 
> kerberos config, which is independent of {{hadoop.ssl.enabled}}. Instead, we 
> should check {{HttpConfig.isSecure()}}.
> Credit to Wing Yew Poon for discovering this bug

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to