[ 
https://issues.apache.org/jira/browse/HADOOP-8917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476481#comment-13476481
 ] 

Arpit Gupta commented on HADOOP-8917:
-------------------------------------

here the test patch output from branch-1

{code}
[exec] 
     [exec] BUILD SUCCESSFUL
     [exec] Total time: 5 minutes 30 seconds
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     -1 tests included.  The patch doesn't appear to include any new 
or modified tests.
     [exec]                         Please justify why no tests are needed for 
this patch.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning 
messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number 
of javac compiler warnings.
     [exec] 
     [exec]     -1 findbugs.  The patch appears to introduce 9 new Findbugs 
(version 1.3.9) warnings.
     [exec] 
     [exec] 
     [exec] 
     [exec] 
     [exec] 
======================================================================
     [exec] 
======================================================================
     [exec]     Finished build.
     [exec] 
======================================================================
     [exec] 
======================================================================
     [exec] 
     [exec] 

{code}
find bugs warnings are not related to this patch and no tests were added as 
TestSecurityUtil has appropriate coverage
                
> add LOCALE.US to toLowerCase in SecurityUtil.replacePattern
> -----------------------------------------------------------
>
>                 Key: HADOOP-8917
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8917
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 3.0.0
>            Reporter: Arpit Gupta
>            Assignee: Arpit Gupta
>         Attachments: HADOOP-8917.branch-1.patch, HADOOP-8917.patch
>
>
> see 
> https://issues.apache.org/jira/browse/HADOOP-8878?focusedCommentId=13472245&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13472245
>  for more details

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to