[ 
https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476877#comment-13476877
 ] 

Gopal V commented on HADOOP-8921:
---------------------------------

I've personally wasted over an hour to figure out that option has to be 
explicitly disabled before it skips running autoconf/automake (in 
create-configure part).

The older approach was bad for someone who did a git checkout and ran a build 
without paying attention to the docs about native library compatibility. 

I'd say the optimizations (i.e non-core features) can be skipped over for a 
clean build on platforms where the code won't compile / isn't supported. Every 
single attempt to build on a Mac would result in a failed compilation, until 
someone discovers the -Dcompile.native option. 

Clean builds on "ant compile" should be encouraged (on any platform) without 
RTFMing for a -D option.

Of course on platforms where the native code is indeed supported, it would 
error out if say, JNI headers can't be found.
                
> ant build.xml in branch-1 ignores -Dcompile.native
> --------------------------------------------------
>
>                 Key: HADOOP-8921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8921
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.2.0
>         Environment: Mac OS X 10.7.4
>            Reporter: Gopal V
>            Priority: Trivial
>              Labels: ant, autoconf, patch
>         Attachments: HADOOP-8921.4.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any <target if> conditions are checked only 
> after the dependencies are run through. The current if condition in code 
> fails to prevent the autoconf/libtool components from running.
> Fixing it by moving the if condition up into the "compile-native" target and 
> changing it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to