[
https://issues.apache.org/jira/browse/HADOOP-8929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13476899#comment-13476899
]
Hudson commented on HADOOP-8929:
--------------------------------
Integrated in Hadoop-Yarn-trunk #5 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/5/])
HADOOP-8929. Add toString, other improvements for SampleQuantiles.
Contributed by Todd Lipcon. (Revision 1398658)
Result = FAILURE
todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1398658
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/lib/MutableQuantiles.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/Quantile.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/util/SampleQuantiles.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/metrics2/util/TestSampleQuantiles.java
> Add toString, other improvements for SampleQuantiles
> ----------------------------------------------------
>
> Key: HADOOP-8929
> URL: https://issues.apache.org/jira/browse/HADOOP-8929
> Project: Hadoop Common
> Issue Type: Improvement
> Components: metrics
> Affects Versions: 3.0.0, 2.0.2-alpha
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Fix For: 3.0.0, 2.0.3-alpha
>
> Attachments: hadoop-8929.txt
>
>
> The new SampleQuantiles class is useful in the context of benchmarks, but
> currently there is no way to print it out outside the context of a metrics
> sink. It would be nice to have a convenient way to stringify it for logging,
> etc.
> Also:
> - made it Comparable and changed the HashMap to TreeMap so that the printout
> is in ascending percentile order. Given that this map is always very small,
> and snapshot() is only called once a minute or so, the runtime/memory
> differences between treemap and hashmap should be negligible.
> - changed the behavior to return null instead of throw, because all the
> catching, etc, got pretty ugly. In implementing toString, I figured I'd clean
> up the other behavior along the way.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
