[ 
https://issues.apache.org/jira/browse/HADOOP-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477390#comment-13477390
 ] 

Hadoop QA commented on HADOOP-8930:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12549388/HADOOP-8930.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1637//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/1637//console

This message is automatically generated.
                
> Cumulative code coverage calculation
> ------------------------------------
>
>                 Key: HADOOP-8930
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8930
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.23.3, 2.0.2-alpha
>            Reporter: Andrey Klochkov
>            Assignee: Andrey Klochkov
>         Attachments: HADOOP-8930.patch
>
>
> When analyzing code coverage in Hadoop Core, we noticed that some coverage 
> gaps are caused by the way the coverage calculation is done currently. More 
> specifically, right now coverage can not be calculated for the whole Core at 
> once, but can only be calculated separately for top level modules like 
> common-project, hadoop-hdfs-project etc. 
> At the same time, some code in particular modules is tested by tests in other 
> modules of Core. For example, "org.apache.hadoop.fs" from 
> hadoop-common-project/hadoop-common is not covered there but it's covered by 
> tests under hadoop-hdfs-project.
> To enable calculation of "cumulative" code coverage it's needed to move 
> Clover profile definition up one level, from hadoop-project/pom.xml to the 
> top level pom.xml (hadoop-main).
> Patch both for 0.23 and 2.x will be attached shortly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to