[ 
https://issues.apache.org/jira/browse/HADOOP-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13477669#comment-13477669
 ] 

Ivan Mitic commented on HADOOP-6496:
------------------------------------

Thanks for reviewing Suresh.

bq. the branch-1.1 patch is missing the addition of file test.css, changes to 
build.xml, HttpServerFunctionalTest.java. Is that intentional?
HttpServerFunctionalTest does not exist in branch-1, that is why I don't have 
any changes around it. 
Other changes (build.xml/test.css) are only related to adding a new 
{{test.css}} test file. However, that introduced unittest regressions in 
branch-1, since Jetty ended up resolving resources against the local test path 
{{build/test/webapps}}. Specifically, {{test.classpath}} would have 
{{build/test/webapps}} before {{build/webapps}} causing many tests dependent on 
files under {{build/webapps}} to fail, since HttpServer binds to an incorrect 
path.

As an alternative, I used an existing {{/static/hadoop.css}} test file. This 
way we have both the fix and a test covering the new functionality. Let me know 
if this makes sense or if you have other proposals.
                
> HttpServer sends wrong content-type for CSS files (and others)
> --------------------------------------------------------------
>
>                 Key: HADOOP-6496
>                 URL: https://issues.apache.org/jira/browse/HADOOP-6496
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.21.0, 0.22.0
>            Reporter: Lars Francke
>            Assignee: Ivan Mitic
>            Priority: Minor
>             Fix For: 0.22.0
>
>         Attachments: HADOOP-6496.branch-1.1.backport.2.patch, 
> HADOOP-6496.branch-1.1.backport.patch, hadoop-6496.txt, hadoop-6496.txt
>
>
> CSS files are send as text/html causing problems if the HTML page is rendered 
> in standards mode. The HDFS interface for example still works because it is 
> rendered in quirks mode, the HBase interface doesn't work because it is 
> rendered in standards mode. See HBASE-2110 for more details.
> I've had a quick look at HttpServer but I'm too unfamiliar with it to see the 
> problem. I think this started happening with HADOOP-6441 which would lead me 
> to believe that the filter is called for every request and not only *.jsp and 
> *.html. I'd consider this a bug but I don't know enough about this to provide 
> a fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to