[
https://issues.apache.org/jira/browse/HADOOP-8874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13478598#comment-13478598
]
Ivan Mitic commented on HADOOP-8874:
------------------------------------
Thanks John for the patch! The patch will also help troubleshoot/root cause
issues where winutils.exe cannot be found (oppose to just silently ignoring the
failure).
Two minor comments:
- Can you please recreate the patch using the {{--no-prefix}} git flag?
Otherwise, the patch does not apply automatically.
- I see a few lines above 80 chars, would be good to shrink them
Otherwise, it looks good.
> HADOOP_HOME and -Dhadoop.home (from hadoop wrapper script) are not uniformly
> handled
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-8874
> URL: https://issues.apache.org/jira/browse/HADOOP-8874
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: scripts, security
> Affects Versions: 1-win
> Environment: Called from external process with -D flag vs HADOOP_HOME
> set.
> Reporter: John Gordon
> Labels: security
> Fix For: 1-win
>
> Attachments: fix_home.patch
>
>
> There is a -D flag to set hadoop.home, which is specified in the hadoop
> wrapper scripts. This is particularly useful if you want SxS execution of
> two or more versions of hadoop (e.g. rolling upgrade). However, it isn't
> honored at all. HADOOP_HOME is used in 3-4 places to find non-java hadoop
> components such as schedulers, scripts, shared libraries, or with the Windows
> changes -- binaries.
> Ideally, these should all resolve the path in a consistent manner, and
> callers shuold have a similar onus applied when trying to resolve an invalid
> path to their components. This is particularly relevant to scripts or
> binaries that may have security impact, as absolute path resolution is
> generally safer and more stable than relative path resolution.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
