[ 
https://issues.apache.org/jira/browse/HADOOP-8947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13480773#comment-13480773
 ] 

Ivan Mitic commented on HADOOP-8947:
------------------------------------

Thanks Chris for porting the changes!

I looked over the patch and tested it out. Overall, this is a great start. One 
minor comment, on branch-1-win, we use DUHelper class to calculate the disk 
usage. Should we include this part in the patch?
                
> need basic merge of branch-1-win to branch-trunk-win to enable initial test 
> pass
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-8947
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8947
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs, util
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8947-branch-trunk-win.patch
>
>
> We need a basic merge of past work contributed on branch-1-win to 
> branch-trunk-win to enable further testing on a trunk-derived version of the 
> codebase on Windows.  Primarily, this involves merging in the changes to 
> FileUtil and Shell to enable calls to winutils.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to