[ 
https://issues.apache.org/jira/browse/HADOOP-8901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481920#comment-13481920
 ] 

Colin Patrick McCabe commented on HADOOP-8901:
----------------------------------------------

One way to do it would be to use something like 
{{get_filename_component(HADOOP_ZLIB_LIBRARY $\{HADOOP_ZLIB_LIBRARY\} 
REALPATH)}} to follow the symlinks all the way to the fully versioned library.  
Then you need to strip off the minor version, which is a small bit of text 
manipulation.

Another way would be to figure out what versions are in use on BSD and hardcode 
those.  Arguably, depending on a specific version is a feature not a bug, since 
the major version number should only be bumped when there was an incompatible 
zlib ABI change that could (in theory) break our code.

If BSD users are convinced that the versionless variant will always be present, 
we could add an IF(BSD) or something to CMakeLists.txt and do it that way.  
Personally I do not have enough knowledge of BSD to say if the devel packages 
are always installed there-- seems strange, to me.
                
> GZip and Snappy support may not work without unversioned libraries
> ------------------------------------------------------------------
>
>                 Key: HADOOP-8901
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8901
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: native
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>             Fix For: 3.0.0, 2.0.3-alpha
>
>         Attachments: HADOOP-8901.001.patch, HADOOP-8901.002.patch, 
> HADOOP-8901.003.patch
>
>
> Currently, we use {{dlopen}} to open {{libz.so}} and {{libsnappy.so}}, to get 
> Gzip and Snappy support, respectively.
> However, this is not correct; we should be dlopening {{libsnappy.so.1}} 
> instead.  The versionless form of the shared library is not commonly 
> installed except by development packages.  Also, we may run into subtle 
> compatibility problems if a new version of libsnappy comes out.
> Thanks to Brandon Vargo for reporting this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to