[
https://issues.apache.org/jira/browse/HADOOP-8972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483812#comment-13483812
]
Ivan Mitic commented on HADOOP-8972:
------------------------------------
Just noticed that this change is incompatible with HADOOP-8874. Specifically,
the following code from TestWinUtils.java:
{code}
File winutilsFile = new File(Shell.WINUTILS + ".exe");
File aExe = new File(TEST_DIR, "a.exe");
Shell.execCommand("cmd", "/c", "copy", winutilsFile.getCanonicalPath(),
aExe.getCanonicalPath());
{code}
will have to be updated to the following (notice that there are no ".exe"
anymore):
{code}
File winutilsFile = new File(Shell.WINUTILS);
File aExe = new File(TEST_DIR, "a.exe");
Shell.execCommand("cmd", "/c", "copy", winutilsFile.getCanonicalPath(),
aExe.getCanonicalPath());
{code}
> Move winutils tests from bat to Java
> ------------------------------------
>
> Key: HADOOP-8972
> URL: https://issues.apache.org/jira/browse/HADOOP-8972
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 1-win
> Reporter: Ivan Mitic
> Assignee: Ivan Mitic
> Attachments: HADOOP-8972.branch-1-win.winutilstests.patch
>
>
> This Jira tracks the work needed to move existing winutils tests from bat
> files to Java. We decided to go with Java for the following reasons:
> 1. It showed to be quite hard to modify bat scripts and add new test cases
> (people are generally not comfortable writing bat scripts)
> 2. Debugging a test case failure in bat script is not trivial
> 3. It turned that we are not running the test scripts frequently
> Cons:
> One now needs JDK and Hadoop jar to compile and run winutils tests. However,
> in the context of Hadoop this is not an issue so we decided to go with
> something we all feel more comfortable with.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
