[
https://issues.apache.org/jira/browse/HADOOP-8456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484769#comment-13484769
]
Ivan Mitic commented on HADOOP-8456:
------------------------------------
Thanks all for the feedback! My answers are below.
bq. AccessControlList depends on a space delimiter, you will need to somehow
address that too.
You bring up a good poing Vinod. I discussed this part with the team before
posting a patch. At this point, we will keep the current HDFS user and group
name semantics, so no spaces. If we decide to make this change, that would be a
separate Jira. The goal of this patch is to provide accurate information to
Hadoop in the first place since providing false information can lead some other
problems. Does this make sense?
bq. 1.Does the wrapping of double quotes around the command args imply that the
windows shell is re-parsing the group name? If so, that would seem to be a
security issue if the user is somehow able to inject input with metachars.
Daryn, I am relatively confident that Windows deals with this stuff properly. I
would assume the same for the thin JNI layer. Passing in paramaters under
quotes means that they are passed as separate args to app underneath (C
argc/argv). Do you maybe know of some problems here?
bq. 2.Maybe turn the delimiter into a general option so it's not hardcoded
throughout the patch?
Make sense, I'll prepare the updated patch.
bq. How does Cygwin, MS SUA, etc handle this problem? We should do the same
thing on Windows in order maintain compatibility with those systems.
Thanks Allen. I just checked using Cygwin's {{id -Gn}}, and it seems that
Cygwin keeps some internal metadata about groups. I know this was also true for
permissions/ownership.
{code}
>id -Gn ivanmi
mkpasswd
{code}
Actual groups:
{code}
>bin\winutils.exe groups ivanmi
AutoSql Admin Group HelpLibraryUpdaters Administrators
{code}
And now with the separator:
{code}
>bin\winutils.exe groups -F ivanmi
AutoSql Admin Group|HelpLibraryUpdaters|Administrators
{code}
Generally, we want to natively integrate Hadoop with Windows, in a sense that
Windows user/group information flows thru Hadoop.
Let me know if this makes sense.
> Support spaces in user names and group names in results returned via winutils
> -----------------------------------------------------------------------------
>
> Key: HADOOP-8456
> URL: https://issues.apache.org/jira/browse/HADOOP-8456
> Project: Hadoop Common
> Issue Type: Bug
> Components: native
> Affects Versions: 1-win
> Reporter: Chuan Liu
> Assignee: Ivan Mitic
> Priority: Minor
> Attachments: HADOOP-8456.branch-1-win.spaces.patch
>
>
> When parsing results returned by ‘ls’, we made implicit assumption that user
> and group names cannot contain spaces. On Linux, spaces are not allowed in
> user names and group names. This is not the case for Windows. We need to find
> a way to fix the problem for Windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
